Convert setup_iptables to ansible role + Fix usertwist group don't exist error + Hardened Systemd unit #5

Closed
Mateo wants to merge 10 commits from dev into main
6 changed files with 98 additions and 19 deletions
Showing only changes of commit 5ebad367b4 - Show all commits

View File

@@ -29,6 +29,10 @@
src: ../templates/Caddyfile.j2
dest: /etc/caddy/Caddyfile
- name: Create the usertwist group
ansible.builtin.group:
name: usertwist
- name: Create the usertwist user
ansible.builtin.user:
name: usertwist
Mateo marked this conversation as resolved
Review

Is this user able to login ?
If so please use No Login https://man7.org/linux/man-pages/man8/nologin.8.html

Is this user able to login ? If so please use No Login https://man7.org/linux/man-pages/man8/nologin.8.html

View File

@@ -0,0 +1,38 @@
Role Name
Mateo marked this conversation as resolved Outdated
Outdated
Review

This looks a bit generic !

This looks a bit generic !
=========
A brief description of the role goes here.
Requirements
------------
Any pre-requisites that may not be covered by Ansible itself or the role should be mentioned here. For instance, if the role uses the EC2 module, it may be a good idea to mention in this section that the boto package is required.
Role Variables
--------------
A description of the settable variables for this role should go here, including any variables that are in defaults/main.yml, vars/main.yml, and any variables that can/should be set via parameters to the role. Any variables that are read from other roles and/or the global scope (ie. hostvars, group vars, etc.) should be mentioned here as well.
Dependencies
------------
A list of other roles hosted on Galaxy should go here, plus any details in regards to parameters that may need to be set for other roles, or variables that are used from other roles.
Example Playbook
----------------
Including an example of how to use your role (for instance, with variables passed in as parameters) is always nice for users too:
- hosts: servers
roles:
- { role: username.rolename, x: 42 }
License
-------
BSD
Author Information
------------------
An optional section for the role authors to include contact information, or a website (HTML is not allowed).

View File

@@ -0,0 +1,34 @@
galaxy_info:
author: Motysten
description: Dev
company: Athelas
# If the issue tracker for your role is not on github, uncomment the
# next line and provide a value
# issue_tracker_url: http://example.com/issue/tracker
# Choose a valid license ID from https://spdx.org - some suggested licenses:
# - BSD-3-Clause (default)
# - MIT
# - GPL-2.0-or-later
# - GPL-3.0-only
# - Apache-2.0
# - CC-BY-4.0
license: license (GPL-2.0-or-later, MIT, etc)
Mateo marked this conversation as resolved
Review

Which license should we pick ?

Which license should we pick ?
min_ansible_version: 2.1
# If this a Container Enabled role, provide the minimum Ansible Container version.
# min_ansible_container_version:
galaxy_tags: []
# List tags for your role here, one per line. A tag is a keyword that describes
# and categorizes the role. Users find roles by searching for tags. Be sure to
# remove the '[]' above, if you add tags to this list.
#
# NOTE: A tag is limited to a single word comprised of alphanumeric characters.
# Maximum 20 tags per role.
dependencies: []
# List your role dependencies here, one per line. Be sure to remove the '[]' above,
# if you add dependencies to this list.

View File

@@ -0,0 +1,17 @@
---
Mateo marked this conversation as resolved
Review

Required change : i'm pretty sure this iptables config does not survive a reboot. Can you check ? What should you do to ensure this config is applied at boot time ?

**Required change** : i'm pretty sure this iptables config does not survive a reboot. Can you check ? What should you do to ensure this config is applied at boot time ?
# tasks file for setup_iptables
- name: Open needed ports
ansible.builtin.iptables:
chain: INPUT
protocol: tcp
in_interface: eth0
jump: ACCEPT
destination_ports:
- "22"
- "443"
- "80"
- name: Set INPUT policy to DROP
ansible.builtin.iptables:
chain: INPUT
policy: DROP

View File

@@ -1,20 +1,6 @@
- name: Edit iptables settings
hosts: athelas
become: true
tasks:
- name: Open needed ports
ansible.builtin.iptables:
chain: INPUT
protocol: tcp
in_interface: eth0
jump: ACCEPT
destination_ports:
- "22"
- "443"
- "80"
- name: Set INPUT policy to DROP
ansible.builtin.iptables:
chain: INPUT
policy: DROP
roles:
- setup_iptables